System version doesn't need to match when assigning a code #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A code assigned with a system may include a version as part of the system. This is generally intended to refer to the system's published version in the world, and is not guaranteed to match the version of the CodeSystem FHIR resource. Fish for any version when resolving the system, and do not emit a warning even if the versions don't match.
cmoesel
reviewed
Aug 3, 2023
src/fhirtypes/common.ts
Outdated
| @@ -952,9 +952,12 @@ export function replaceReferences<T extends AssignmentRule | CaretValueRule>( | |||
| } | |||
| } | |||
| } else if (value instanceof FshCode) { | |||
| // the version on a CodeSystem resource is not the same as the system's actual version out in the world. | |||
| // so, they don't need to match. | |||
| const baseSystem = value.system?.split('|')[0]; | |||
| const codeSystemMeta = fishForMetadataBestVersion( | |||
There was a problem hiding this comment.
Since we're removing the version, I think this can just be fishForMetadata now, right @jafeltra?
There was a problem hiding this comment.
Yep! For simplicity, fishForMetadata should be sufficient. Looking at the implementation of fishForMetadata, if there is no | in the the value passed in, it actually doesn't make any difference and will only try to call fishForMetadata. But based on how we've used these functions, we've only been using fishForBestMetadata in the cases where we want the version match or the next best thing.
|
I didn't notice anything else, besides the small change @cmoesel suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1305 and completes task CIMPL-1147.
A code assigned with a system may include a version as part of the system. This is generally intended to refer to the system's published version in the world, and is not guaranteed to match the version of the CodeSystem FHIR resource. Fish for any version when resolving the system, and do not emit a warning even if the versions don't match.